-
Notifications
You must be signed in to change notification settings - Fork 55
feat: add notebook to upgrade shared tier #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
c75dcc2
to
d81043b
Compare
@@ -17,7 +17,7 @@ | |||
] | |||
}, | |||
{ | |||
"id": "bd0ae268", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the ids changing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to run this by @kesmit13, because its one of the pre-commit hooks that changes that. I might be using it wrong.
tags=["starter", "notebooks", "fusion"] | ||
lesson_areas=[] | ||
destinations=["spaces"] | ||
minimum_tier="free-shared" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the minimum tier be trial or standard, since this operation cannot be performed on the free tier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trial is not an option for this field, we use free-shared when we want something available on trial. Or can bump it to Standard and not make it available for Trial.
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"<div class=\"alert alert-block alert-warning\">\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can combine them, yes.
The first one is the default indication on what this notebook can be ran. (Also, just realized that the second sentence is wrong, ill have to remove that)
The second one's purpose is to state that while you can run this on a shared tier you need to be able of creating a workspace group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rodriguespn, pls check the lastest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some typos and the text overall is confusing. It feels like there's not much context about this notebook and each cell on the notebook itself
Yes, I'll have to get either the UX or docs team involve to polish this experience. |
Add notebook to upgrade shared tier vws to dedicated workspace groups
https://memsql.atlassian.net/browse/MCDB-75127