Skip to content

feat: add notebook to upgrade shared tier #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

j-fitas
Copy link
Collaborator

@j-fitas j-fitas commented Jun 16, 2025

Add notebook to upgrade shared tier vws to dedicated workspace groups

https://memsql.atlassian.net/browse/MCDB-75127

@j-fitas j-fitas requested a review from Rodriguespn June 16, 2025 13:08
@j-fitas j-fitas self-assigned this Jun 16, 2025
@j-fitas j-fitas marked this pull request as ready for review June 30, 2025 12:40
@j-fitas j-fitas force-pushed the MCDB-75127/add-upgrade-notebook branch from c75dcc2 to d81043b Compare June 30, 2025 19:49
@@ -17,7 +17,7 @@
]
},
{
"id": "bd0ae268",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the ids changing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to run this by @kesmit13, because its one of the pre-commit hooks that changes that. I might be using it wrong.

tags=["starter", "notebooks", "fusion"]
lesson_areas=[]
destinations=["spaces"]
minimum_tier="free-shared"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the minimum tier be trial or standard, since this operation cannot be performed on the free tier?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trial is not an option for this field, we use free-shared when we want something available on trial. Or can bump it to Standard and not make it available for Trial.

"cell_type": "markdown",
"metadata": {},
"source": [
"<div class=\"alert alert-block alert-warning\">\n",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something weird about having two consecutive "Alert" blocks in the notebook. Is it possible to merge them?

image

Also, I was confused about the difference between the two alerts. Aren't they saying the same?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can combine them, yes.
The first one is the default indication on what this notebook can be ran. (Also, just realized that the second sentence is wrong, ill have to remove that)
The second one's purpose is to state that while you can run this on a shared tier you need to be able of creating a workspace group.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rodriguespn, pls check the lastest commit.

Copy link

@Rodriguespn Rodriguespn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some typos and the text overall is confusing. It feels like there's not much context about this notebook and each cell on the notebook itself

@j-fitas
Copy link
Collaborator Author

j-fitas commented Jul 8, 2025

There are some typos and the text overall is confusing. It feels like there's not much context about this notebook and each cell on the notebook itself

Yes, I'll have to get either the UX or docs team involve to polish this experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants