Use yarn cache on local and RA #279
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidferlay
reviewed
Sep 3, 2020
| only: | ||
| variables: | ||
| - $THEME_PATH | ||
| - $YARN_CACHE_FOLDER |
There was a problem hiding this comment.
This line should be removed imho, cause front jobs should be triggered only by theme defined, and nothing else (currently front job will try to run even if theme is not initialized yet, because YARN_CACHE_FOLDER is defined)
davidferlay
reviewed
Sep 3, 2020
| - web/themes/custom/XXX/package.json # ... this path has to be hardcoded | ||
| - web/themes/custom/XXX/yarn.lock # ... this path has to be hardcoded | ||
| paths: | ||
| - ${THEME_PATH}/node_modules/ # Populated during yarn install |
There was a problem hiding this comment.
I don't see reason to move this to "only_var_theme" anchor
Can you please explain motivation ?
andypost
reviewed
Oct 24, 2022
| @@ -53,6 +56,7 @@ front-build: | |||
| docker pull $(IMAGE_FRONT); \ | |||
| $(call frontexec, node -v); \ | |||
| $(call frontexec, yarn -v); \ | |||
| $(call frontexec, yarn install --ignore-optional --check-files --prod); \ | |||
There was a problem hiding this comment.
bad idea to keep it in the same dir as theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up front jobs both on local and gitlab CI by keeping yarn cache in local directory