Skip to content

Fix deprecated ProgressView for Android #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix deprecated ProgressView for Android #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Sources/SkipUI/SkipUI/Components/ProgressView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,13 @@ public struct ProgressView : View {
if value == nil || total == nil {
LinearProgressIndicator(modifier: modifier, color: color)
} else {
LinearProgressIndicator(progress: Float(value! / total!), modifier: modifier, color: color)
LinearProgressIndicator(
progress: { Float(value! / total!) },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the deprecated API fix. I'd like to leave everything else as using default values (i.e. just exclude the gapSize and drawStopIndicator parameters) for the normal Compose look. We can eventually add custom modifiers to change the Material view, as we've done for other components.

And could you also make the fix for CircularProgressIndicator?

modifier: modifier,
color: color,
gapSize = -8.dp, // Makes sure the progress overlaps the background
drawStopIndicator = {}
)
}
}

Expand Down