retry - Add more names to __all__

[tjstum]

Summary

In async_handler, the AsyncRetryHandler wasn't being explicitly exported. This looks like an oversight.

In http_retry, there is the "default" ServerErrorRetryHandler. Import this and and to __all__

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.
• I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

[salesforce-cla]

Thanks for the contribution! Before we can merge this, we need @tjstum to sign the Salesforce Inc. Contributor License Agreement.

[tjstum]

Hi there,

We need to be able to sign the CLA as a company. Can you provide some information on how Salesforce would like us to proceed?

[WilliamBergamin]

These changes look good 💯 thanks for putting them together

I dug up the PRs that introduced ServerErrorRetryHandler #1367, #1372 and #1378, and it does appear like excluding it from all_builtin_retry_handlers was an oversight

@zimeg is investigating signing the CLA as a company

[zimeg]

👋 @tjstum The CLA above will need to be signed by individual contributors given employer approval, as needed 🏛️

Do let us know when this is signed for the first time! We'll have to refresh checks from the kind @salesforce-cla 🤖 ✨

[tjstum]

Hi @zimeg. Thanks for that information.

The CLA contains information about a legal entity signing the CLA and providing a list of employees (section 3.5 and the reference to "Schedule A"). How do we submit that on the cla.salesforce.com? How do we provide the list of employees (and their association with the legal entity that will be signing the CLA)?

[zimeg]

@tjstum Since your contribution is from a personal account, section 3.4 should be alright here:

3.4 If You are an individual employed by another individual or a legal entity, You represent that Your employer has waived any of its rights in Your Contributions.

I'd recommend emailing [email protected] from a corporate address to coordinate further, but I understand most contributions are signed with an individual CLA when needed - both related to Salesforce and not.

[tjstum]

@zimeg I tried to email [email protected] with a similar inquiry, but the email bounced. Is there a different contact?

I'm also not sure what you mean by "personal account." What other sort of GitHub account is there that's relevant here?

Here was my message, in case you want to route it internally:

I am trying to contribute code to the python-slack-sdk package, which is maintained by Salesforce. As I am making contributions on behalf of my employer, we'll need to sign the license agreement under the relevant legal entity.

The CLA, in section 3.5, contemplates signing the CLA as a legal entity, but I am not sure how to effect such a signature through the web application. Additionally, the CLA mentions "Schedule A" as a way to indicate employees that are eligible to contribute under the signed CLA.

Can you provide some guidance on this? For other projects, we've signed the CLA as a company, provided the list of GitHub user names (or email addresses). Some projects also require individual signatures to the CLA (but without the employer waiving its rights).

Thanks!

[zimeg]

@tjstum Hmm... I didn't expect that to happen. Going to ask about this bounced email 📬

I'm also not sure what you mean by "personal account." What other sort of GitHub account is there that's relevant here?

The account that submits a contribution is the one we check for a signed CLA with using @salesforce-cla[bot] and applies to section 3.4. I do believe signing the CLA as an individual signals that the contribution follows the CLA, but I'll ask about this as well.

Bot accounts make often automated changes to projects and we might have a different process for accepting these changes. The kind @dependabot[bot] comes to mind 🙏 ✨