Skip to content

CCIP - make required config types public and update legacy snapshot function args #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CCIP - make required config types public and update legacy snapshot function args #1415

wants to merge 1 commit into from

Conversation

ogtownsend
Copy link
Contributor

@ogtownsend ogtownsend commented Jul 18, 2025 •
edited
Loading

  • A few of the config poller related structs were private when they were defined in cl-ccip. However, since they now live in cl-common and we need to access them in cl-ccip and other repos, they need to be public.
  • Updates GetAllConfigLegacySnapshot(...) function args since it needs to have knowledge of which chain is the dest chain when constructing the batch read query

@ogtownsend ogtownsend changed the title CCIP - make required config types public and update legacy snapshot f… CCIP - make required config types public and update legacy snapshot function args Jul 18, 2025
@ogtownsend ogtownsend mentioned this pull request Jul 18, 2025
Draft
@ogtownsend ogtownsend marked this pull request as ready for review July 18, 2025 05:11
@ogtownsend ogtownsend requested a review from a team as a code owner July 18, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@matYang matYang Awaiting requested review from matYang matYang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@AmrMohamedRezk AmrMohamedRezk Awaiting requested review from AmrMohamedRezk AmrMohamedRezk is a code owner automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ogtownsend