Apply tls-roots cargo feature to reqwest #597
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
June 25, 2025 07:59
Head branch was pushed to by a user without write access
tomhoule
force-pushed
the
reqwest-tls-native-certs
branch
from
1cfcda7 to
3f53259
Compare
tomhoule
commented
Jun 25, 2025
|
Some minor linting errors, but then good to go |
The tls-roots feature makes axum discover system TLS certificates through rustls-native-certs, but not reqwest. This PR changes that so that the corresponding feature on reqwest is activated as well, so e.g. oidc discovery requests behave the same as gRPC requests with regards to TLS certificates.
auto-merge was automatically disabled
July 7, 2025 08:09
Head branch was pushed to by a user without write access
tomhoule
force-pushed
the
reqwest-tls-native-certs
branch
from
3f53259 to
0ad2cf1
Compare
tomhoule
commented
Jul 7, 2025
| @@ -55,7 +55,7 @@ api-settings-v2 = ["api-common", "zitadel-gen/zitadel-settings-v2" ] | |||
| api-user-v2 = ["api-common", "zitadel-gen/zitadel-user-v2" ] | |||
|
|
|||
|
|
|||
| tls-roots = ["tonic/tls-roots"] | |||
| tls-roots = ["tonic/tls-roots", "reqwest/rustls-tls-native-roots"] | |||
There was a problem hiding this comment.
This is the only relevant line. The rest of the PR is to make existing code pass CI with the newest toolchain and clippy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tls-roots feature makes axum discover system TLS certificates through rustls-native-certs, but not reqwest. This PR changes that so that the corresponding feature on reqwest is activated as well, so e.g. oidc discovery requests behave the same as gRPC requests with regards to TLS certificates.
I have no previous familiarity with this project other than as a user, so feedback is very welcome.