fix: Fix default value for string-backed enums #939
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes code for determining default value for Smithy Enum types (i.e. Swift enum w/ raw value of type String.)
The previous default value code was incorrect (it constructed an enum case name from the raw value when those two values are not necessarily related.) It worked for names that closely match the raw value and do not contain numbers. A pending model change breaks these assumptions, and a compile error results.
Instead, the approach for determining
IntEnum
raw values is adapted, which is correct - search the Smithy Enum's members to find one whose raw value matches the default value, then use the name of that member to derive the Swift default value.Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.