Make block number not optional in txs #1643
Open
+51
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciszekjob
approved these changes
Aug 13, 2025
This reverts commit 5411f0b.
| 0.28.0-rc.4 Migration guide | ||
| *************************** | ||
|
|
||
| Version 0.28.0-rc.4 of **starknet.py** comes with partial support for RPC 0.9.0 (without the support for changes in the Websockets methods). |
There was a problem hiding this comment.
Let's reform it so it says the support for RPC API is fully compatible but websockets aren't.
Comment on lines
+93
to
+94
| block_hash = Felt(data_key="block_hash", load_default=None) | ||
| block_number = fields.Integer(data_key="block_number", required=True) |
There was a problem hiding this comment.
In spec both fields are required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes