Add update notifier and skip version check option #175
Conversation
🦋 Changeset detectedLatest commit: 31ada70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -12,6 +14,7 @@ export async function main(argv: string[]) { | |||
|
|
|||
| // Get app info from package.json | |||
| const app = getAppInfo() | |||
| const notifier = updateNotifier({ pkg: app }) | |||
There was a problem hiding this comment.
For this to work as expected, it doesn't make sense to wait 24 hours to notify. Instead, we want to make this check always and forget about the interval all together. So the updateCheckInterval should be configured and set to 0.
Also, this const notifier = updateNotifier(...) is defined too early, this doesn't need to be defined if skipVersionCheck is enabled. So this should go right before running the notifier, and only when skipVersionCheck is not set.
| @@ -28,6 +31,10 @@ export async function main(argv: string[]) { | |||
| console.warn(args) | |||
| } | |||
|
|
|||
| if (!args.skipVersionCheck) { | |||
| notifier.notify() | |||
There was a problem hiding this comment.
This logic is not handling anything? No custom message if versions are not met?
Currently, it just lets the notify go do it's thing, but no custom instructions on what to run instead, nor halting the process (as per the issue this PR aims to fix).
This means that the notification will (probably?) happen after the user completed the wizard, which is not what we're after.
One because it's too late (the user might already have issues before we tell them to update).
Second issue is that the message is incorrect. The default message suggests to do a global install, whereas create-solana-dapp is only supported to run using npx or npm create (or variations based on the package manager).
This version check should happen before any prompts, and after the package manager is selected so that we can give a specific instruction on what to run.
Added
Update notifier
Addresses #155
Version check is skippable (In case we want to add a blocking check in the future).