Skip to content

added upload artifact step to the test workflow #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

borisnieuwenhuis
Copy link

So you can access the test result from the containing workflow and publish the test results

@Woody4618
Copy link
Collaborator

Thank you for this. Why do you need a test results file, when you can see the test results in the actions tab already? Whats the workflow that this helps with?

@borisnieuwenhuis
Copy link
Author

borisnieuwenhuis commented Apr 28, 2025

@Woody4618 I would like to see it in the pr summary, see image below. The actions tab is far out of context, you have to also drill down in the run-tests step, there you see this report, but it is far away.

'''

Running test suite: "/home/runner/work/crunchdao-protocol/crunchdao-protocol/Anchor.toml"

PASS tests/crunch.spec.ts (51.567 s)
PASS tests/coordinator.spec.ts (10.579 s)
PASS tests/staking.spec.ts (5.276 s)
PASS tests/idlutils.spec.ts

Test Suites: 4 passed, 4 total
Tests: 2 skipped, 46 passed, 48 total
Snapshots: 0 total
Time: 68.403 s
Ran all test suites.
'''

Also I might want to publish code coverage report etc. Would like to have clearer and more prominent presentation for it then deep down in an action step.

image

@Woody4618
Copy link
Collaborator

Woody4618 commented Apr 28, 2025

I see, cool! Could you add to the readme how to set this up? How the test file should look like for anchor tests. Then i will try it out and then we can merge it. Great addition :)

@borisnieuwenhuis
Copy link
Author

@Woody4618 I will change it a bit, now it is too much focussed on test results. I think you should be able to download any artifact that gets produced in the test run. I will come up with a more generic setup

@Woody4618
Copy link
Collaborator

I think its ok if its focused on test results. Running the tests should be as straight forward as possible if we can get an easy and nice test result that is a win. If someone wants to upload other artifacts they can also just add another step to their workflow probably. But happy to see what you come up with :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants