Add HLD for aggregate VOQ counters. #1957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
This was referenced Apr 9, 2025
|
/azp run |
|
No pipelines are associated with this pull request. |
|
|
||
| ### Overview | ||
|
|
||
| In a [distributed VOQ architecture](https://github.com/sonic-net/SONiC/blob/master/doc/voq/architecture.md) corresponding to each output VOQ present on an ASIC, there are VOQs present on every ASIC in the system. Each ASIC has its own set of VOQ stats maintained in the FSI that have to be gathered independently and can be hard to visualize, providing a non-cohesive experience. |
There was a problem hiding this comment.
@vivekverma-arista Can we use term line card instead of FSI ?
| Send traffic across different ASICs and ensure aggregate counters are correctly displayed. | ||
|
|
||
| ### Limitations and future work | ||
| 1. Currently we are not exposing redis instance over midplane IP for single ASIC linecards as redis runs in protected mode. |
There was a problem hiding this comment.
@vivekverma-arista How will this feature work for system having mix of J2C+ as well as J2 based line cards? Since some of J2 cards are single asic, are you saying those counters won't be part of counter aggregation on SUP?
There was a problem hiding this comment.
The support will be added incrementally
|
|
||
| ### Limitations and future work | ||
| 1. Currently we are not exposing redis instance over midplane IP for single ASIC linecards as redis runs in protected mode. | ||
| 2. Clear functionality is not supported as of now for aggregate VOQ counters. |
There was a problem hiding this comment.
@vivekverma-arista Do we have issue open in github to track this ?
vmittal-msft
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document provides general information about the feature aggregate VOQ counters in a distributed VOQ architecture.
This feature has been tracked in #1543
Code PRs for tracking
The code pull requests should merge in the order they are mentioned in the table.