Skip to content

fix: Filter team formation list #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2025
Merged

Conversation

RichDom2185
Copy link
Member

image

Team formation on the frontend shows all teams ever created even if not part of the course.

@RichDom2185 RichDom2185 requested a review from GabrielCWT July 1, 2025 03:09
@RichDom2185 RichDom2185 self-assigned this Jul 1, 2025
@RichDom2185 RichDom2185 changed the title Filter team formation list fix: Filter team formation list Jul 1, 2025
@RichDom2185 RichDom2185 enabled auto-merge (squash) July 1, 2025 05:06
@coveralls
Copy link

coveralls commented Jul 1, 2025

Coverage Status

coverage: 92.473% (+0.004%) from 92.469%
when pulling 99c50b1 on filter-team-formation-list
into 8466108 on master.

@RichDom2185 RichDom2185 disabled auto-merge July 1, 2025 14:56
@RichDom2185 RichDom2185 enabled auto-merge (squash) July 1, 2025 14:56
@RichDom2185 RichDom2185 merged commit 41026f5 into master Jul 1, 2025
2 of 3 checks passed
@RichDom2185 RichDom2185 deleted the filter-team-formation-list branch July 1, 2025 15:02
tckeong added a commit that referenced this pull request Jul 9, 2025
* build(deps): Bump sentry from 11.0.0 to 11.0.1 (#1263)

Bumps [sentry](https://github.com/getsentry/sentry-elixir) from 11.0.0 to 11.0.1.
- [Release notes](https://github.com/getsentry/sentry-elixir/releases)
- [Changelog](https://github.com/getsentry/sentry-elixir/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-elixir@11.0.0...11.0.1)

---
updated-dependencies:
- dependency-name: sentry
  dependency-version: 11.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): Bump phoenix_ecto from 4.6.4 to 4.6.5 (#1266)

Bumps [phoenix_ecto](https://github.com/phoenixframework/phoenix_ecto) from 4.6.4 to 4.6.5.
- [Changelog](https://github.com/phoenixframework/phoenix_ecto/blob/main/CHANGELOG.md)
- [Commits](https://github.com/phoenixframework/phoenix_ecto/commits/v4.6.5)

---
updated-dependencies:
- dependency-name: phoenix_ecto
  dependency-version: 4.6.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: Filter team formation list (#1268)

* Add new method

* Use new method

* Fix credo error

* Fix and update tests

* fix: reduce warnings when running tests (#1270)

* replace warn with warning

"warning: the log level :warn is deprecated, use :warning instead"

* empty doc

"warning: module attribute @doc was set but no definition follows it"

* replace '' with ""

"warning: using single-quoted strings to represent charlists is deprecated."

* move function

"clauses with the same name and arity (number of arguments) should be grouped together"

* make range explicit

"10..0 has a default step of -1, please write 10..0//-1 instead"

* remove alias

"unused alias"

* rename unused variables

"warning: variable "XXX" is unused"

* remove choices from validate_required

"""
warning: attempting to determine the presence of embed_many field :choices with validate_required/3 ... which has no effect.
You can pass the :required option to Ecto.Changeset.cast_embed/3 to achieve this.
"""

* delete unused variables instead

* Revert "remove choices from validate_required"

This reverts commit 088fa96.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Richard Dominick <[email protected]>
Co-authored-by: heyzec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants