fix: reduce warnings when running tests #1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyzec
commented
Jul 1, 2025
"warning: the log level :warn is deprecated, use :warning instead"
"warning: using single-quoted strings to represent charlists is deprecated."
"clauses with the same name and arity (number of arguments) should be grouped together"
"10..0 has a default step of -1, please write 10..0//-1 instead"
"unused alias"
"warning: variable "XXX" is unused"
""" warning: attempting to determine the presence of embed_many field :choices with validate_required/3 ... which has no effect. You can pass the :required option to Ecto.Changeset.cast_embed/3 to achieve this. """
This reverts commit 088fa96.
tckeong
added a commit
that referenced
this pull request
Jul 9, 2025
* build(deps): Bump sentry from 11.0.0 to 11.0.1 (#1263) Bumps [sentry](https://github.com/getsentry/sentry-elixir) from 11.0.0 to 11.0.1. - [Release notes](https://github.com/getsentry/sentry-elixir/releases) - [Changelog](https://github.com/getsentry/sentry-elixir/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-elixir@11.0.0...11.0.1) --- updated-dependencies: - dependency-name: sentry dependency-version: 11.0.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): Bump phoenix_ecto from 4.6.4 to 4.6.5 (#1266) Bumps [phoenix_ecto](https://github.com/phoenixframework/phoenix_ecto) from 4.6.4 to 4.6.5. - [Changelog](https://github.com/phoenixframework/phoenix_ecto/blob/main/CHANGELOG.md) - [Commits](https://github.com/phoenixframework/phoenix_ecto/commits/v4.6.5) --- updated-dependencies: - dependency-name: phoenix_ecto dependency-version: 4.6.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Filter team formation list (#1268) * Add new method * Use new method * Fix credo error * Fix and update tests * fix: reduce warnings when running tests (#1270) * replace warn with warning "warning: the log level :warn is deprecated, use :warning instead" * empty doc "warning: module attribute @doc was set but no definition follows it" * replace '' with "" "warning: using single-quoted strings to represent charlists is deprecated." * move function "clauses with the same name and arity (number of arguments) should be grouped together" * make range explicit "10..0 has a default step of -1, please write 10..0//-1 instead" * remove alias "unused alias" * rename unused variables "warning: variable "XXX" is unused" * remove choices from validate_required """ warning: attempting to determine the presence of embed_many field :choices with validate_required/3 ... which has no effect. You can pass the :required option to Ecto.Changeset.cast_embed/3 to achieve this. """ * delete unused variables instead * Revert "remove choices from validate_required" This reverts commit 088fa96. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard Dominick <[email protected]> Co-authored-by: heyzec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to reduce the number of warnings emitted when running
mix test. There are still some warnings left, reasons for which are not fixed mainly below to the following two categories: