Skip to content

Use new test environment format for Jest #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

Use new test environment format for Jest #3250

merged 2 commits into from
Jul 15, 2025

Conversation

RichDom2185
Copy link
Member

Description

Actually, this is the expected way to define environments in the current Jest major version. But I think there might be some backwards compatibility of sorts, thus it still ran on Linux CI as well as my Windows. But it wouldn't on my Mac.

Now it does.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 requested a review from sayomaki July 15, 2025 11:19
@RichDom2185 RichDom2185 self-assigned this Jul 15, 2025
@RichDom2185 RichDom2185 enabled auto-merge (squash) July 15, 2025 11:19
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16291864236

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 44.619%

Changes Missing Coverage Covered Lines Changed/Added Lines %
jsdom-env.js 0 1 0.0%
Totals Coverage Status
Change from base Build 16291861472: -0.002%
Covered Lines: 10111
Relevant Lines: 21225

💛 - Coveralls

Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 684476e into master Jul 15, 2025
9 checks passed
@RichDom2185 RichDom2185 deleted the fix-test-macos branch July 15, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants