qml: ExceptionDialog: put user_text inside Flickable #10051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tested on android, works as expected |
accumulator
reviewed
Jul 21, 2025
| id: user_text | ||
| Layout.fillWidth: true | ||
| Flickable { | ||
| width: parent.width |
There was a problem hiding this comment.
Avoid binding width (or height, x, y) in direct children of Layout. Direct children should as a rule of thumb always use Layout attached properties, e.g. Layout.fillWidth: true, or Layout.preferredWidth: 100, as Layout takes control of these properties in its children.
| TextArea { | ||
| id: user_text | ||
| Layout.fillWidth: true | ||
| Flickable { |
There was a problem hiding this comment.
Note that there is controls/ElTextArea that aims to solve the scrolling issue as well (albeit still a bit glitchy in its current form). It is used in e.g. SignVerifyMessageDialog.qml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to make the dialog better behave if the user types a lot of text.
note: I have not tested on Android.