Add support for Satochip hardware wallet #9972
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include new wizard Qt desktop client spesmilo#8560 WIP TODO: build binaries, adapt qrcodewidget
In satochip plugin, a user can setup a 2FA using a qrcode. The cancel button allows the user to cancel this action.
flake8 . --count --select="$ELECTRUM_LINTERS" --ignore="$ELECTRUM_LINTERS_IGNORE" --show-source --statistics --exclude "*_pb2.py,electrum/_vendor/" ./electrum/plugins/satochip/__init__.py:6:23: W292 no newline at end of file available_for = ['qt'] ^ 1 W292 no newline at end of file
bitcoin.py/transaction.py: API changes: rm most hex usage See also spesmilo@2f10955
Using: $ ELECTRUM_LINTERS='E,F,W,C90,B'
Remove unused imports, variables & code
Close message dialog correctly when using 2FA
…-v4.6.x-0.12 # Conflicts: # contrib/deterministic-build/requirements-hw.txt
* add manifest.json for Satochip plugin * move hw_wallet.py from plugins to electrum library
Toporin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to add support for the Satochip hardware wallet.
The Satochip hardware wallet is based on a jacavard smartcard and is fully open-source.
The wallet is composed of a javacard applet that is to be loaded on the smartcard, and an Electrum client plugin that acts as the interface between the card and the network.
Using the new plugin architecture, it might be possible to add Satochip support through a plugin. However, I think this might still require to include some dependencies in the electrum core code:
Your guidance is greatly appreciated!
This pull request updates and supersedes #8967.
More info:
https://github.com/Toporin/ (official repository)
https://pypi.org/project/pysatochip/ (pysatochip library)
https://prezi.com/p/mpq-xhh3mxjl/satochip-gent-meetup/ (Slides from previous meetups in Belgium)
https://t.me/Satochip (Telegram support)