Skip to content

outbound-networking (mostly) refactoring #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lann
Copy link
Collaborator

@lann lann commented Jun 18, 2025

A hodgepodge of refactoring extracted from a larger (but now smaller) change:

  • Tweak/add doc comments
  • Fix spin_expressions Template Display
  • Replace HostConfig::List(Vec<String>) with HostConfig::Literal(url::Host)
    • List was only ever exactly one item
    • url::Host provides validation and normalization
  • Add HostConfig::literal(host)
  • Reorganize error handling a bit
    • This does change some validation error messages, making them more consistent but also introduces some use of anyhow Context which is more verbose
  • Add AllowedHostConfig::is_for_service_chaining, replacing logic in spin-loader
  • Capricious rename HostConfig::new test helper to ::unwrap_literal

@lann lann force-pushed the allowed-hosts-refactoring branch from 6e39bb7 to 7e119db Compare June 18, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant