Debug failing HttpEventCollector_Log4j2Test #210
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirm that the HttpEventCollector_Log4j2Test is failing on the main branch.
The test is failing in both #207 and #208
I suspect the test failure is unrelated to any changes from those pull requests, and will fail also on the main branch.
Unfortunately, the
println
statements from the failing test are missing from the GitHub CI output.This pull request aims to further debug this failing test by:
Adding a TestWatcher rule to log test name on start,
Consolidate the "Test Pass" messages,
And, flush stdout when each test completes.
You can see here (https://github.com/splunk/splunk-library-javalogging/runs/4001980946?check_suite_focus=true#step:6:1111) that the output from the failing test is not included.
I would expect to see the output from the
System.out.println
statements here: https://github.com/stevejagodzinski/splunk-library-javalogging/blob/feature/use-jdk8-source-features/src/test/java/HttpEventCollector_Log4j2Test.java#L269