-
Notifications
You must be signed in to change notification settings - Fork 120
CSPL-3357: Enforce Acknowledgment of Splunk General Terms (SGT) #1496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rlieberman-splunk
wants to merge
16
commits into
feature/splunk10
Choose a base branch
from
CSPL_3357_configmap
base: feature/splunk10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto CSPL_3357_configmap
kasiakoziol
reviewed
May 5, 2025
kasiakoziol
reviewed
May 5, 2025
kasiakoziol
reviewed
May 5, 2025
kasiakoziol
approved these changes
May 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there way to simplify this to say "ACCEPT_SPLUNK_GENERAL_TERMS" and value as "yes" or "no" . and in the code we can pass "--accept-current-at-splunk-com" to docker image
kasiakoziol
reviewed
Jul 10, 2025
kasiakoziol
reviewed
Jul 10, 2025
kasiakoziol
reviewed
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This description was generated in part by GitHub Copilot.
Description
This pull request introduces changes to support a mandatory acknowledgment mechanism for the Splunk General Terms (SGT) in the Splunk Operator for Kubernetes. The updates include adding a new
SPLUNK_GENERAL_TERMS
environment variable, modifying deployment configurations, and updating documentation to guide users on the new requirements.Key Changes
Configuration Updates
SPLUNK_GENERAL_TERMS
with a default empty value in multiple configuration files, includingMakefile
,kustomization.yaml
, and deployment manifests. This variable must be set to"--accept-sgt-current-at-splunk-com"
to comply with the SGT acknowledgment mechanism. [1] [2] [3] [4] [5]Deployment Behavior
SPLUNK_GENERAL_TERMS
variable, ensuring it is passed during deployment or artifact generation. [1] [2] [3]Documentation Enhancements
README.md
anddocs/Install.md
on how to configure theSPLUNK_GENERAL_TERMS
variable during deployment. [1] [2]SplunkGeneralTermsMigration.md
, explaining the motivation, impact, and migration steps for the SGT acknowledgment mechanism.Minor Fixes
docs/AppFramework.md
(changed "LicenceManager" to "LicenseManager").Testing and Verification
Related Issues
PR Checklist