Skip to content

Conversation

LyubovSugak
Copy link
Collaborator

note about deployment requirement after changes in doPlugin global is done

note about deployment requirement after changes in doPlugin global is done

This extension is the result of a refactoring and generalization process of the various existing DoPlugins extensions.
The goal of the refactoring was to have only one centralized version of this extension which can be used on all brand
profiles. [Read more](https://github.com/spring-media/ds_cmp_tealium_extension/blob/master/extensions/doPlugins_global.README.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand why you removed the link to doPlugin readme?

The different features are organized as simple Javascript objects which are attached to the global S-Object which
is provided by the Adobe Analytics tag.

!!! After changes are done in DoPlugins global extension to make it live the deployment in Tealium is required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That happens to all files in github, not only doPlugin. When they are used in Tealium a deployment is needed.

The different features are organized as simple Javascript objects which are attached to the global S-Object which
is provided by the Adobe Analytics tag.

!!! After changes are done in DoPlugins global extension to make it live the deployment in Tealium is required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That happens to all files in github, not only doPlugin. When they are used in Tealium a deployment is needed.

The different features are organized as simple Javascript objects which are attached to the global S-Object which
is provided by the Adobe Analytics tag.

!!! After changes are done in DoPlugins global extension to make it live the deployment in Tealium is required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That happens to all files in our repo, not only doPlugin. When they are used in Tealium a deployment is needed.

Copy link
Contributor

@nickyanalytics nickyanalytics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a more generell info would be more helpfull. You can also add current NMG List where user can check if file is linked in Tealium. BTW I forgot Businessinsider in the list I send you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants