Skip to content

Fixed GH-3466: Fixed the logic error in the validateToolContextSupport method of MethodToolCallback #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed GH-3466: Fixed the logic error in the validateToolContextSupport method of MethodToolCallback #3478

wants to merge 1 commit into from

Conversation

sunyuhan1998
Copy link
Contributor

Fixes #3466

As mentioned in the PR, there were some issues with the implementation of the validateToolContextSupport method in MethodToolCallback, which led to validation failures. This PR makes the following adjustments:

  1. Adjusted the parameter order when calling ClassUtils.isAssignable to ensure correct semantics.
  2. Modified the condition for throwing exceptions to align with the method's intended functionality.

@sunyuhan1998
fix: Fixed spring-projectsGH-3466, corrected a logic error in the `va…
7aee9ae 
…lidateToolContextSupport` method caused by incorrect parameter order.

Signed-off-by: Sun Yuhan <[email protected]>
@sunyuhan1998 sunyuhan1998 mentioned this pull request Jun 9, 2025
Open
@sunyuhan1998 sunyuhan1998 changed the title Fixed the logic error in the validateToolContextSupport method of MethodToolCallback Fixed GH-34665: Fixed the logic error in the validateToolContextSupport method of MethodToolCallback Jun 9, 2025
@sunyuhan1998 sunyuhan1998 changed the title Fixed GH-34665: Fixed the logic error in the validateToolContextSupport method of MethodToolCallback Fixed GH-3466: Fixed the logic error in the validateToolContextSupport method of MethodToolCallback Jun 9, 2025
@ilayaperumalg ilayaperumalg self-assigned this Jun 10, 2025
@ilayaperumalg ilayaperumalg added this to the 1.1.x milestone Jun 10, 2025
@ilayaperumalg ilayaperumalg added bug Something isn't working for: backport-to-1.0.x labels Jun 11, 2025
@ilayaperumalg
Copy link
Member

Rebased and merged as 59d2661. Also, back-ported the fix into 1.0.x via 2ca1be2

@sunyuhan1998 sunyuhan1998 mentioned this pull request Jun 11, 2025
Closed
@ilayaperumalg ilayaperumalg mentioned this pull request Jun 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ilayaperumalg ilayaperumalg

Labels
bug Something isn't working for: backport-to-1.0.x tool/function calling
Projects
None yet
Milestone
1.1.0.M1
Development

Successfully merging this pull request may close these issues.

Wrong implementation of MethodToolCallback.validateToolContextSupport
2 participants
@sunyuhan1998 @ilayaperumalg