GH-4494: Fix anthropic model auto-configuration #4550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loveysuby
force-pushed
the
GH-4494-fix-anthropic-auto-configuration
branch
from
fb6c14f to
f02f95e
Compare
Related to spring-projects#4494 Signed-off-by: Hyoseop Song <[email protected]>
loveysuby
force-pushed
the
GH-4494-fix-anthropic-auto-configuration
branch
from
f02f95e to
7477666
Compare
loveysuby
changed the title
|
@loveysuby Thanks for the PR! Rebased and merged as 110605f |
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4494
This PR fixes conflicts in
AnthropicChatAutoConfigurationby removing@ImportAutoConfigurationand keeping only the proper@AutoConfigurationsetup.It also adds
BaseAnthropicITto encapsulate Anthropic integration tests and stabilize configuration behavior.I'm also wondering if having a separate Base{LLM_PROVIDER}IT per model provider is necessary, since they mostly replicate dependency setup from each auto-configuration.