This incorrect binding was really giving me issues. Not sure why it works #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orks or why it works differently. You can see the bug in action in my fork where I fixed this in 95d1aee. I would be curious to know what is going on here.
|
This actually shouldn't be necessary. Controllers implement all the methods of their content. What issue are you trying to fix? |
|
I've implemented simple search functionality in the fork. If you checkout the repo before the above commit you'll find that with every search request items are being duplicated. With the commit this simple search works perfectly. I'm using 1.5.0 for this repo, with rc1 the other way works (but the counter is not updated correctly). So either I screwed up in this tiny app or a bug was introduced after rc1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorrect binding was really giving me issues. Not sure why it works or why it works differently. You can see the bug in action in my fork where I fixed this in jeroenvandijk@95d1aee.
I would be curious to know what is going on here.