fix: automatically determine NiFi version create reporting task script #1189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we use custom versions now, the wrong NiFi version was passed to the script (
1.28.1
instead of1.28.1-stackable0.0.0-dev
for example). Since it's a bit hard to determine the actual SDP version of the NiFi image in the operator and this is just needed for NiFi 1 which will eventually be deprecated, I decided to just let the script determine the NiFi version on the go. It still has the-v
parameter, we could remove it but that would require the operator to not pass it as well. I decided to go the easy non-breaking way and just leave it in, even though it's not used anymore.Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
bake
to retrieve the image tag for<image-tagged-with-the-major-version>
.