feat: automatic cluster detection #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
sbernauer
requested changes
Jul 2, 2025
|
That was a quick implementation, didn't expect that! :) |
Co-authored-by: Sebastian Bernauer <[email protected]>
sbernauer
previously approved these changes
Jul 3, 2025
sbernauer
approved these changes
Jul 3, 2025
sbernauer
previously approved these changes
Jul 3, 2025
Co-authored-by: Sebastian Bernauer <[email protected]>
sbernauer
previously approved these changes
Jul 3, 2025
sbernauer
approved these changes
Jul 3, 2025
sbernauer
moved this from Development: In Review
to Development: Done
in Stackable Engineering
nightkr
reviewed
Jul 3, 2025
Comment on lines
+54
to
+60
| let api: Api<Node> = Api::all(client.clone()); | ||
| let nodes = api | ||
| .list(&ListParams::default()) | ||
| .await | ||
| .context(ListNodesSnafu)?; | ||
| let node = nodes.iter().next().context(EmptyKubernetesNodesListSnafu)?; | ||
| let node_name = node.name_any(); |
There was a problem hiding this comment.
We can inject this through the downwards API instead.
There was a problem hiding this comment.
slick! forgot about that :(
This was referenced Jul 3, 2025
lfrancke
moved this from Development: Done
to Acceptance: In Progress
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes stackabletech/issues#662
Definition of Done Checklist
Author
Reviewer
Acceptance