Added /v3/tenures/blocks/{consensus_hash} endpoint #6431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

rdeioris wants to merge 20 commits into stacks-network:develop from rdeioris:feat/tenureblocks_endpoint

Contributor

rdeioris commented Sep 1, 2025

Description

This patch adds the first (of 3) new endpoints allowing getting the list of stacks blocks given a burnblock (here by consensus hash, next endpoints will cover height and block hash).

It is part (along the simulation block api #6346) of the features required by wormhole.


          added getenureblocks endpoint

5dee45a

rdeioris requested review from a team as code owners

September 1, 2025 13:31


          updated changelog

ae3db15

Jiloc reviewed

View reviewed changes

Contributor

Jiloc left a comment

You are missing the update to the openapi spec

Jiloc reviewed

View reviewed changes

stackslib/src/net/api/tests/gettenureblocks.rs Outdated Show resolved Hide resolved

stackslib/src/net/api/gettenureblocks.rs Outdated Show resolved Hide resolved

stackslib/src/net/api/gettenureblocks.rs Outdated Show resolved Hide resolved

stackslib/src/net/api/gettenureblocks.rs Outdated Show resolved Hide resolved

stackslib/src/net/api/gettenureblocks.rs Outdated Show resolved Hide resolved

stackslib/src/net/api/gettenureblocks.rs Outdated Show resolved Hide resolved

stackslib/src/net/api/gettenureblocks.rs Outdated Show resolved Hide resolved

stackslib/src/net/api/gettenureblocks.rs Outdated Show resolved Hide resolved

stackslib/src/net/api/gettenureblocks.rs Outdated Show resolved Hide resolved

stackslib/src/net/api/gettenureblocks.rs Outdated Show resolved Hide resolved

jcnelson reviewed

View reviewed changes

stackslib/src/chainstate/nakamoto/mod.rs Outdated Show resolved Hide resolved

jcnelson reviewed

View reviewed changes

stackslib/src/net/api/gettenureblocks.rs Outdated Show resolved Hide resolved

jcnelson reviewed

View reviewed changes

stackslib/src/net/api/gettenureblocks.rs Show resolved Hide resolved

jcnelson reviewed

View reviewed changes

stackslib/src/net/api/gettenureblocks.rs Outdated Show resolved Hide resolved

jcnelson reviewed

View reviewed changes

stackslib/src/net/api/gettenureblocks.rs Show resolved Hide resolved

jcnelson reviewed

View reviewed changes

stackslib/src/net/api/tests/gettenureblocks.rs Show resolved Hide resolved

rdeioris added 8 commits

September 3, 2025 12:52


          added openapi stanza

4d0d14e


          use inline formatting

ffe92fc


          another round of inline formatting

f421f31


          removed useless map_err

be80218


          more formatting fixes and use BurnchainHeaderHash instead of string

dbe1e9c


          added streamed output for RPCTenure

8e9b269


          removed useless function as it is not fork-aware

162fb39


          added json streaming

4a0ec8d

rdeioris requested review from jcnelson and Jiloc

September 3, 2025 16:37

Contributor Author

rdeioris commented Sep 3, 2025

Note: i rollbacked the BurnHeaderHash usage as it serializes to an array of numbers by default.

jcnelson reviewed

View reviewed changes

stackslib/src/chainstate/stacks/db/mod.rs Outdated Show resolved Hide resolved

jcnelson reviewed

View reviewed changes

stackslib/src/net/api/gettenureblocks.rs Show resolved Hide resolved

jcnelson reviewed

View reviewed changes

Member

jcnelson left a comment

LGTM; just a couple nits and then I'll approve

rdeioris added 2 commits

September 4, 2025 07:20


          rename header_type to header_type_name

f303817


          added docstrings

c38d029

rdeioris requested a review from jcnelson

September 4, 2025 05:35

Jiloc reviewed

View reviewed changes

docs/rpc/openapi.yaml Show resolved Hide resolved

stackslib/src/net/api/gettenureblocks.rs Outdated Show resolved Hide resolved

docs/rpc/openapi.yaml Show resolved Hide resolved

docs/rpc/openapi.yaml Outdated Show resolved Hide resolved

docs/rpc/openapi.yaml Outdated Show resolved Hide resolved

stackslib/src/net/api/gettenureblocks.rs Show resolved Hide resolved

stackslib/src/net/api/gettenureblocks.rs Outdated Show resolved Hide resolved

stackslib/src/net/api/gettenureblocks.rs Show resolved Hide resolved

rdeioris added 5 commits

September 4, 2025 12:43


          removed useless comment

814d551


          improved parameter description

5b1a8b0


          improved parameter description [2]

d75ffc5


          inline formatting

a4de697


          added openapi schemas and example

3283af8

rdeioris requested a review from Jiloc

September 4, 2025 11:57


          added example

608fe5e

Jiloc reviewed

View reviewed changes

Contributor

Jiloc left a comment

waiting for the tests to wrap up before approving, but LGTM!

rdeioris requested a review from Jiloc

September 4, 2025 14:30

Jiloc previously approved these changes

View reviewed changes

jcnelson reviewed

View reviewed changes

docs/rpc/components/schemas/tenure-blocks.schema.yaml Outdated Show resolved Hide resolved

jcnelson reviewed

View reviewed changes

docs/rpc/components/schemas/tenure-blocks.schema.yaml Outdated Show resolved Hide resolved

jcnelson reviewed

View reviewed changes

Member

jcnelson left a comment

LGTM; just a doc typo needs to be fixed


          fixed typo and improved description of json output

c67e3e0

rdeioris dismissed Jiloc’s stale review via

c67e3e0

September 5, 2025 10:29

rdeioris requested review from jcnelson and Jiloc

September 5, 2025 10:29

Jiloc approved these changes

View reviewed changes


          Merge branch 'develop' into feat/tenureblocks_endpoint

13b7011

rdeioris requested a review from Jiloc

September 5, 2025 15:49

Jiloc approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet