Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a
rated
bool column and arated_position
integer column to thedemons
table (representing the demon's position on the list with only rated demons)for stats viewers,
unrated_rank
andunrated_score
columns are added for everyrank
andscore
column that currently existsthe majority of struct and query changes are just refactoring to account for these new columns
for passing list context information in the backend i just made a
List
enum so i dont need to pass around anis_rated_list
bool of some sort everywherein the frontend it's a
data-list
attribute in the html tag for css and awindow.active_list
for the jsfor the different list pages, the uris are now
/<list>/...
as opposed to always being/demonlist/...
(so rated+ pages would be/ratedplus/...
)world map in stats viewers are now in the same context as the rest of the document as opposed to being in its own object context, so use of differently colored heatmaps is possible just by referencing different stylesheets in the document head
also russian translations are still missing but ill commit those later
if theres anything that needs the most testing it's the movement logs and time machine 🥺
this general implementation already went through zoe, she also asks that this doesnt get merged or deployed until shes done with her side of the rated+ work
resolves #279
License Acceptance
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.