Fix deprecation warnings #78
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we encounter an exact match on requested_field with allowed_scopes do not continue to check for additional filter with attribute and predicate.
|
Fixed in #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
#media_typeinstead. (called from block in add_renderer! /xxxxx/vendor/cache/jsonapi.rb-b69123b0aa03/lib/jsonapi/rails.rb:93)#media_typeinstead. (called from block in add_errors_renderer! at /xxxxx/vendor/cache/jsonapi.rb-b69123b0aa03/lib/jsonapi/rails.rb:40)What is the new behavior?
No warnings
Checklist
Please make sure the following requirements are complete:
features)