-
Notifications
You must be signed in to change notification settings - Fork 14
Doc for ChatOps #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Doc for ChatOps #230
Conversation
Add more context to the project.
chatops_deployment/docs/INSTALL.md
Outdated
|
||
## OpenStack Project Requirements: | ||
|
||
The project `KHalford-Scratch-Space` is already setup with all the required requisites. The variables in this project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the project name be generic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it can. That was leftover from my initial draft. I'll make the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Add instructions on how to deploy, configure and destroy. merge update install.md
Add information about the inventories
Add information about the terraform deployment and what each module does.
Add information about the services
Renaming the workflow as this name is what is shown in the status badge in the read me
chatops_deployment/docs/INSTALL.md
Outdated
1. Install Ansible (preferably into a virtual environment) and collections | ||
```shell | ||
# Using pip or another package manager | ||
pip install ansible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work for Ubuntu 24.04+ because installing using pip without a venv will bail. Also Ansible is sensitive to the Python version, so on an LTS Ubuntu it's likely pip Ansible will stop playing nice with the system python
I would simply add steps to
apt install python3-venv ansible
python3 -m venv venv
source venv/bin/activate
ansible-galaxy install...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the change. I didn't mean to force push though. History is the same just check the latest commit.
Updating instructions to use a venv to ensure compatability with later Ubuntu OS versions.
LGTM, but there's linter errors which need resolving first |
Linting requires variables on roles to have the role name prepended to them
Resolved in latest commit |
Adding docs for ChatOps deployment. They are not completed but it's more than before.