fix: add correct HTML parsing #273
Conversation
Added rehypeRaw to help with parsing the raw HTML inside the markdown files since markdown-it and react-markdown escapes HTML tags to prevent Cross-SIte Scripting.
✅ Deploy Preview for startling-capybara-2231ea ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hey @orama254 thanks for the PR, it seems you've addressed all, but this one which is still not fixed |
|
Hey @pavlenex, I noticed this while implementing the fix. There's a small blocker on how to access the spec files directly because I observed they were committed as submodules(referencing a remote repository HERE). There's a way that the markdown files on the I have a strategy that would resolve this but I wanted to seek clarity on whether I can proceed with tweaking the remote reference to the spec files inside this pull request or on a separate pull request inside the remote repository. If option 1 is ok I'll have to make a separate pull request on the remote repository It's some exciting git stuff behind the scene and I'm up for the task as I have already mapped out the whole procedure based on carefully analyzing how both repositories work. Let me know. |
|
@orama254 I don't understand what your approach is, you can try to do it in this PR. |
Add submodule reference for docs edit
Revert back to the original submodule reference after debugging
Add the ability for a contributor to view build changes locally
Regenerated content files
rereference original submodule after finishing with the debugging.
|
@pavlenex I just realized I was overestimating the magnitude of the task! It was a simple fix on the global css file. My previous approach was assuming that it was how the markdown files were being converted from markdown to HTML. Turns out the elements were just hidden! I've addressed the pending changes. |
src/specification
Outdated
There was a problem hiding this comment.
Can you explained why changes in this file?
app/src/data/specification.json
Outdated
There was a problem hiding this comment.
Can you explained why changes in this file?
app/src/data/blog-posts.json
Outdated
There was a problem hiding this comment.
Can you explained why changes in this file?
revert to the initial repo state for the generated files and the reference commit for the submodules file. NOTE: add a git ignore file for the app/src/data folder to avoid json regeneration commits in future
Added rehypeRaw to help with parsing the raw HTML inside the markdown files since markdown-it and react-markdown escapes HTML tags to prevent Cross-SIte Scripting.
This pull request resolves #261 and #267