RowSelectionBehaviorAPI #1978
RowSelectionBehaviorAPI #1978
Conversation
gbirch-stripe
requested review from
charliecruzan-stripe and
a team
as code owners
gbirch-stripe
changed the title
| displayMessage = "An unexpected error occurred", | ||
| ) | ||
| } | ||
| @Composable |
There was a problem hiding this comment.
Why was also this logic moved to Content?
There was a problem hiding this comment.
We don't have the rowSelectionBehaviorType upon initialization, so by putting the builder in Content we can assure that that data is available and we can pass it to the native Android component
There was a problem hiding this comment.
Can you do a LaunchedEffect for rowSelectionBehaviorType in Content? Tagging in @tianzhao-stripe as he implemented this on native android, any thoughts here?
There was a problem hiding this comment.
Yea, we want to do a launchedEffect for the validation logic, with the key being the rowSelectionBehaviorType so that it doesn't run everytime we have a recomposition
There was a problem hiding this comment.
Latest status on this:
For clarification, it is not the validation logic that needs to run after EmbeddedPaymentElementView is initialized (the validation is done in the javascript layer) but rather setting the rowSelectionBehavior on the builder. Tian and I worked on this some but haven't reached an acceptable solution. Input from Android engineers on the best way to solve this would be appreciated.
…sibile/accessibility text
| const isImmediateAction = | ||
| configuration.rowSelectionBehavior?.type === 'immediateAction'; | ||
| const isFormSheetConfirm = configuration.formSheetAction?.type === 'confirm'; | ||
| const isApplePayEnabled = !!configuration.applePay; | ||
| const hasCustomerConfig = !!configuration.customerId; |
There was a problem hiding this comment.
Can we not rely on the native code to error out here? I guess Android and iOS error at different times, but seems possible?
| * - In the `default` case, the payment method option row enters a selected state. | ||
| * - In the `immediateAction` case, `onSelectPaymentOption` is called. | ||
| */ | ||
| export type EmbeddedRowSelectionBehavior = |
There was a problem hiding this comment.
Just double checking, RowSelectionBehavior was already implemented on the iOS bridge right?
| @@ -152,6 +172,7 @@ class EmbeddedPaymentElementView( | |||
| is Event.Confirm -> { | |||
| embedded.confirm() | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Nit: Unneeded blank line
Summary
rowSelectionBehavior API - adds immediateAction option.
Added new example screen to showcase immediateAction option with modal.
Motivation
The rowSelectionBehavior API provides merchants with more flexibility, especially those who wish to use the Embedded Element as a selection sheet. This API exists on iOS and Android, and this PR brings React Native into alignment with them.
https://jira.corp.stripe.com/browse/MOBILESDK-3619
Testing
Documentation
Select one: