flatWithChevron API #1979
Open
flatWithChevron API #1979
+116
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbirch-stripe
requested review from
charliecruzan-stripe and
a team
as code owners
…/flatWithChevron-MOBILESDK-3618
…/flatWithChevron-MOBILESDK-3618
Comment on lines
+291
to
+292
| if (!isImmediateAction && isFlatWithChevron) { | ||
| return "The 'flatWithChevron' row style can only be used with 'immediateAction' row selection behavior. Set rowSelectionBehavior to 'immediateAction' or use a different row style."; |
There was a problem hiding this comment.
Same w/ my other comment in the other PR. Would be nice to not have to duplicate this logic if we don't have to since both native SDKs already do this validation.
| topSeparatorEnabled = topEnabled, | ||
| bottomSeparatorEnabled = bottomEnabled, | ||
| additionalVerticalInsetsDp = additionalInsets, | ||
| horizontalInsetsDp = 0.0F, // We do not have an iOS equal for this API so it's not configurable in React Native |
There was a problem hiding this comment.
@porter-stripe was this not added for iOS embedded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
flatWithChevron API. PR only points to rowselectionbehavior branch for now since this is a sub-branch depending on it
Motivation
Matching iOS and Android SDKs. The new style adds an option for merchants that may better align with their design language and more seamlessly integrate the Embedded Payment Element into their app.
https://jira.corp.stripe.com/browse/MOBILESDK-3618?filter=-1
API review: https://docs.google.com/document/d/1z_MZtnsGuAZtGaaxAUOjffMSywIpdoO9v5yZOJbbxCA/edit?tab=t.0
Testing
Documentation
Select one: