fix(isthmus): handle subqueries with outer field references #426
+1,266
−960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the sake of reviewability could I ask you split this into 3-ish PRs. One for your initial cleanups/improvements, one for just the visitor changes, and one for subquery changes. |
Sure, I already thought that this might be necessary. |
|
First extracted PR for the visitor changes: #427 |
nielspardon
force-pushed
the
par-tpch-17
branch
5 times, most recently
from
7b6ef99 to
764206a
Compare
|
I removed the cleanup from this PR and rebased it on #427 |
…isitor BREAKING CHANGE: adds a new context argument to RelVisitor, ExpressionVisitor and FuncArgVisitor Signed-off-by: Niels Pardon <[email protected]>
fixes substrait-io#382 Signed-off-by: Niels Pardon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
SubstraitRelNodeConverterandExpressionRexConverterto support handling subqueries with outer field referencesfixes #382
replaces #383