refactor: improve error handling and optimize memory allocation #2354
+29
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR improves error handling and memory allocation in two key areas:
The
parse_rustc_version
function currently usesexpect()
which can cause panics with unclear error messages when encountering unexpected rustc version formats. This makes debugging difficult and reduces reliability.The
chunk_vec
function creates unnecessary memory allocations when processing large vectors, which can impact performance in memory-intensive operations.Solution
Enhanced
parse_rustc_version
to return a properResult
type instead of usingexpect()
, providing more informative error messages and allowing callers to handle errors gracefully.Optimized
chunk_vec
with pre-allocation strategies:extend
instead ofcollect
to avoid intermediate allocationsPR Checklist