refactor: use pg WaitEvent API instead of epoll #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so the translation to pg WaitEvent API is easier.
This allows compiling on other platforms such as MacOS.
It mostly works at this stage but with some limitations:
- [ ] Doing 10K requests fail with "Bad file descriptor"
+ I believe this is because we're not deleting file descriptors
since the WaitEvent API doesn't provide EPOLL_CTL_DEL.
It only provides EPOLL_CTL_ADD/MOD
- [ ] timerfd is still Linux specific and pg provides no abstraction
over it.
|
Since there's no EPOLL_CTL_DEL on the pg API, let's use a simpler approach for now on #165. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows compiling on other platforms such as MacOS. (problem previously mentioned on #139 (comment))
It mostly works at this stage but with some limitations: