fix(pydantic): model_validate_json causing code break with pydantic v1 #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntic v1 Add model_validate_json methods which works with both pydantic v1 and v2
silentworks
changed the title
grdsdev
approved these changes
Jun 17, 2025
Pull Request Test Coverage Report for Build 15708952945Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix: Add model_validate_json methods which works with both pydantic v1 and v2
What is the current behavior?
An error is thrown if you use pydantic v1 with this library
What is the new behavior?
The library is now compatible with both pydantic v1 and v2
Additional context
Fixes #608