fix: Update img proxy env to be consistent with prod #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 16456212330Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
A couple environment variables used by imgproxy in prod are not included when running locally. This results in inconsistent behavior when resizing images locally compared to prod
What is the new behavior?
Include values for
IMGPROXY_PRESETSandIMGPROXY_FORMAT_QUALITYthat match the settings used in prodAdditional context
Specifically, the default behavior for resize when providing only one dimension (height OR width) is to use the resize type of "cover" which will not work if a default preset is not defined. This causes very different behavior than prod which can cause a frustrating experience for users.
This change resolve the issue explained in this discussion: https://github.com/orgs/supabase/discussions/37316