Skip to content

completed Binary Search 1 #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kowshhal
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:
    • The student demonstrates a strong understanding of binary search and its variations.
    • The code is clean, well-commented, and easy to follow.
    • The student correctly identifies and handles edge cases in all problems.
  • Areas for Improvement:
    • In the rotated sorted array solution, the comment "go to un-sorted side since element can't be found in sorted side" could be more precise. It might be clearer to say "go to the other half since the target is not in the current sorted half."
    • The function name get_cordinates in the matrix search solution has a typo ("cordinates" should be "coordinates"). Attention to detail in naming is important for readability.
    • The print statement in the matrix search solution (print(matrix[x][y])) should be removed as it is unnecessary for the solution and could affect performance in large matrices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants