Skip to content

Completed 2/3 #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

shantanujoshi25
Copy link

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • The student has correctly implemented binary search algorithms for both problems.
  • The code is clean, readable, and follows good practices.
  • The time and space complexity annotations are accurate and helpful.

Areas for Improvement:

  • For Problem_1.py, the comment about time complexity could be more precise. Instead of "O(log nm) nxm is shape of matrix," it could be "O(log (n*m)) where n is the number of rows and m is the number of columns."
  • The print statement in Problem_2.py (print(mid)) is unnecessary for the final solution and should be removed to avoid clutter in the output.
  • The student should ensure that the problem descriptions are clear and match the reference solution's context, as the reference solution was for a different problem (binary search in a rotated sorted array).

@shantanujoshi25
Copy link
Author

Completed 3/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants