Skip to content

Completed BinarySearch-1 #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

joelkny97
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:
    • The student has a good understanding of binary search and its application in different scenarios (sorted rotated array and 2D matrix).
    • The code is clean, well-commented, and easy to follow.
    • The student correctly identifies the time and space complexity and handles edge cases appropriately.
  • Areas for Improvement:
    • In Exercise 1, the comment "since array is sorted row wise" could be expanded to clarify that the matrix is sorted in a way that allows it to be treated as a flattened sorted array.
    • In Exercise 2, the condition if not nums or len(nums) == 0 is redundant since not nums already covers the case where nums is empty. The student could simplify this to if not nums.

@joelkny97
Copy link
Author

Completed Problem 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants