Skip to content

Completed Binary Search-Problem 1 #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tanishkasonar22
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths: Your code is well-written and correctly implements a binary search for a 2D matrix problem. The logic is clear, and the variable names are appropriate.
  • Areas for Improvement: You need to ensure that you are solving the correct problem. The reference solution is for searching in a rotated sorted array, not a 2D matrix. Please double-check the problem statement before implementing your solution. Additionally, the file name and function name should match the problem requirements.

@super30admin
Copy link
Owner

  • The student's solution is well-written and efficient for searching in a 2D matrix, but it does not address the problem of searching in a rotated sorted array.
  • The student should carefully read the problem statement to ensure they are solving the correct problem.
  • For the given problem, the student should implement a binary search that accounts for the rotation in the sorted array, similar to the reference solution.
  • The student's approach to binary search is correct for the problem they solved, so they can apply similar logic to the correct problem with some adjustments for the rotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants