Skip to content

Complete Design-1 #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Complete Design-1 #2459

wants to merge 1 commit into from

Conversation

mihir-s30
Copy link

No description provided.

@super30admin
Copy link
Owner

  • MinStack: Excellent implementation. The use of two stacks to maintain values and minimums is efficient and correctly implemented. The comments are clear and helpful.
  • MyHashSet: Very good implementation. The double hashing technique is correctly applied. One minor improvement could be to handle the edge case for key 1,000,000 by adjusting the secondary bucket size, similar to the reference solution. This would ensure complete coverage of all possible keys without any collisions.

Overall, the student has done a great job. The solutions are correct, efficient, and well-structured. The minor optimization in MyHashSet is not critical but would make the solution more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants