Implement remove method #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentfretin
commented
Jun 15, 2023
| this.stars = null; | ||
|
|
||
| // create ground | ||
| this.groundMaterial = null; |
There was a problem hiding this comment.
The same line is at line 178 below.
vincentfretin
commented
Jun 15, 2023
| this.groundMaterialProps.shading = this.environmentData.flatShading ? THREE.FlatShading : THREE.SmoothShading; | ||
| } else { | ||
| this.groundMaterialProps.flatShading = this.environmentData.flatShading; | ||
| } |
There was a problem hiding this comment.
We only support aframe 1.3.0 and above with the current code related to geometries, so we can remove this material check.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly remove all the created entities, and dispose of manually (not via aframe components) created materials and geometries, and reset fog when the component is removed.
There may still have some textures, programs, geometries in memory left though, but at least all entities are removed from the scene.
This is a more complete version of #27