[CAS] Add a new API in ObjectStore to import a CAS tree #10839
+163
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangmuir
reviewed
Jun 13, 2025
cachemeifyoucan
force-pushed
the
eng/PR-cas-import-tree
branch
from
487eced to
9292e05
Compare
benlangmuir
reviewed
Jun 13, 2025
cachemeifyoucan
force-pushed
the
eng/PR-cas-import-tree
branch
2 times, most recently
from
474a066 to
7e4fe68
Compare
|
@swift-ci please test llvm |
benlangmuir
reviewed
Jun 16, 2025
| @@ -125,6 +125,55 @@ bool llcas_cas_options_set_option(llcas_cas_options_t c_opts, const char *name, | |||
|
|
|||
| namespace { | |||
|
|
|||
| using HasherT = SHA1; | |||
There was a problem hiding this comment.
@akyrtzi any concerns about changing the cas plugin test dylib to use SHA1 so that it differs from the builtin CAS?
Add a new API to ObjectStore that can import a cas tree from another CAS. The two ObjectStores don't have to share the same hashing algorithm since all the objects will be rehashed and inserted into the new database. As part of the better testing support, the test plugin CAS library now uses SHA1 hashing which is different from default BLAKE3 hasher as builtin CAS. The test plugin library can be used to test interaction of CAS of different schemas.
cachemeifyoucan
force-pushed
the
eng/PR-cas-import-tree
branch
from
7e4fe68 to
41bdb56
Compare
|
@swift-ci please test llvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new API to ObjectStore that can import a cas tree from another CAS. The two ObjectStores don't have to share the same hashing algorithm since all the objects will be rehashed and inserted into the new database.
As part of the better testing support, the test plugin CAS library now uses SHA1 hashing which is different from default BLAKE3 hasher as builtin CAS. The test plugin library can be used to test interaction of CAS of different schemas.