Apply exhaustive swift-format configuration from swift-syntax #2231
+344
−249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the exhaustive swift-format configuration from swiftlang/swift-syntax#3117 to sourcekit-lsp. Also apply all automatic formattings.
- I think there are valid calls with mixing inline and trailing closures (notably `Debouncer`), so I’m considering whether we should disable that rule. - The `forEach` rule is a little annoying because we have `forEach` on `SKDResponseArray`. But it caught two cases of using `forEach` on arrays, so I think it’s worth keeping.
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please test |
bnbarham
approved these changes
Aug 11, 2025
There was a problem hiding this comment.
I think there are valid calls with mixing inline and trailing closures (notably Debouncer), so I’m considering whether we should disable that rule.
Either seems fine to me
The forEach rule is a little annoying because we have forEach on SKDResponseArray. But it caught two cases of using forEach on arrays, so I think it’s worth keeping.
Yeah, maybe we should rename the SKD case? forEachSKD :)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the exhaustive swift-format configuration from swiftlang/swift-syntax#3117 to sourcekit-lsp. Also apply all automatic formattings.
From the linter rules that needed manual fixing (addressed those in a separate commit), I have two findings, would like to hear other opinions here as well:
Debouncer), so I’m considering whether we should disable that rule.forEachrule is a little annoying because we haveforEachonSKDResponseArray. But it caught two cases of usingforEachon arrays, so I think it’s worth keeping.