Update FreeBSD packaging script #443
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodingCarpincho
requested review from
shahmishal,
compnerd and
etcwilde
as code owners
compnerd
reviewed
Jul 25, 2025
We need to make two changes: - First, the package e2fsprogs-libuuid is no longer shipped and the standard libuuid is used instead. We should therefore update the package manifest to reflect this change in the dependencies. - Second, hard-coding package versions into the script is not very scaleable and will be a maintainence burden. Instead, we should ensure that the minimum package version required is whatever the build machine running this script has.
CodingCarpincho
force-pushed
the
freebsd-script-fixes
branch
from
94bb4a6 to
7f29a79
Compare
|
I've gone ahead and removed some of the dependencies from the package manifest because as @michael-yuji pointed out, they are required by I am leaving the libxml2 and sqlite dependencies unchanged since we do need these dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make two changes:
e2fsprogs-libuuidis no longer shipped and the standardlibuuidis used instead. We should therefore update the package manifest to reflect this change in the dependencies.