Fixes to the AppKit/NSImage overlay.
#1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR (#869) that just added the AppKit overlay for `NSImage` was a bit stale. This PR corrects a couple of bugs that snuck in due to its age and the resulting bit rot.
grynspan
added
attachments/activities
|
@swift-ci test |
stmontgomery
reviewed
Jul 2, 2025
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| #if SWT_TARGET_OS_APPLE && canImport(AppKit) | |||
| public import AppKit | |||
| @_spi(ForSwiftTestingOnly) @_spi(Experimental) public import _Testing_CoreGraphics | |||
| @_spi(Experimental) public import _Testing_CoreGraphics | |||
There was a problem hiding this comment.
I guess there were not any package declarations needed currently?
stmontgomery
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR (#869) that just added the AppKit overlay for
NSImagewas a bit stale. This PR corrects a couple of bugs that snuck in due to its age and the resulting bit rot.Checklist: