Implement experimental module selectors (MyMod::someName) feature #34556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccadax
changed the title
beccadax
force-pushed
the
mod-squad-2
branch
3 times, most recently
from
eb8ecdf to
b6d41f6
Compare
beccadax
commented
Jul 21, 2021
beccadax
force-pushed
the
mod-squad-2
branch
3 times, most recently
from
9c9e8e9 to
6edf769
Compare
beccadax
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
xymus and
AnthonyLatsis
as code owners
|
Woohoo! Thank you for reviving this, Becca! |
A PatternBindingEntry formed from a MissingPatternSyntax has no valid SourceLocs in it, and a PatternBindingDecl containing only PatternBindingEntries with no valid SourceLocs trips an assertion during availability checking. (Generating dummy SourceLocs can cause invalid overlaps between AvailabilityScopes, so that’s not a workable solution.) The fix is to: • Refuse to generate a PatternBindingEntry from a PatternBindingSyntax with a MissingPatternSyntax (MissingPatternSyntaxes at nested positions don’t have this problem) • Refuse to generate a PatternBindingDecl with no PatternBindingEntries This ensures that the invalid AST nodes are never formed. No current test cases hit this problem, but certain invalid module selector tests can run into this situation when run with ASTGen.
The diagnostics in this test will evolve as we implement pieces of the feature.
Adds comments explaining why these conversions aren’t lossy.
Lookups like Builtin::Int64 were failing because BuiltinUnit rejected all unqualified lookups. Make it allow unqualified lookups with a module selector.
|
@swift-ci please smoke test |
This support is currently opt-in and has several modes.
|
@swift-ci please build toolchain |
|
@swift-ci build toolchain Windows platform |
|
@swift-ci please test |
|
@swift-ci build toolchain Windows platform |
4 similar comments
|
@swift-ci build toolchain Windows platform |
|
@swift-ci build toolchain Windows platform |
|
@swift-ci build toolchain Windows platform |
|
@swift-ci build toolchain Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request begins to implement "module selectors", which allow references to declarations to be unambiguously prefixed with a module they can be found through:
This PR parses module selectors and partially implements lookup and diagnostics for them. The new functionality is hidden behind an
-enable-experimental-module-selectorfrontend flag. There is one diagnostic regression with that flag enabled, but I've made sure that it keeps working when the diagnostic is disabled.This work was previously in PR #28834, which was closed during the master-to-main transition. I've updated it to work on modern compilers, including removing some FIXMEs for bad diagnostics that have improved since December 2019.
Makes progress on rdar://problem/19481048.