Skip to content

SIMD test IR not ASM #82078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025
Merged

Conversation

stephentyrone
Copy link
Contributor

No description provided.

@stephentyrone stephentyrone requested a review from a team as a code owner June 7, 2025 01:29
@stephentyrone
Copy link
Contributor Author

@swift-ci test

…FP16 enabled, so FileCheck was failing when building for those because we didn't have the "right" assembly pattern. Stop testing Float16 compare codegen for now. I'll restore it with an IR test instead of assembly."

This reverts commit 9ca0e14.
The asm tests proved to be too brittle, so on the assumption that LLVM already tests IR -> asm, we'll just test Swift -> IR.
@stephentyrone stephentyrone force-pushed the simd-test-ir-not-asm branch from f942827 to d831acd Compare June 10, 2025 19:44
@stephentyrone
Copy link
Contributor Author

@swift-ci test

On x86 we legalize these to four floats, rather than two 2xfloat, which means we have to rearrange the inputs and they generally won't be in %0 and %1.
@stephentyrone
Copy link
Contributor Author

@swift-ci smoke test

1 similar comment
@stephentyrone
Copy link
Contributor Author

@swift-ci smoke test

@stephentyrone stephentyrone enabled auto-merge (squash) June 12, 2025 20:01
@stephentyrone stephentyrone merged commit b67050b into swiftlang:main Jun 12, 2025
3 checks passed
@stephentyrone stephentyrone deleted the simd-test-ir-not-asm branch June 13, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant