Fix parameter, doc comments in Span family #82102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @glessard |
|
@swift-ci please smoke test |
glessard
requested changes
Jun 9, 2025
| @@ -301,11 +301,11 @@ extension RawSpan { | |||
| @lifetime(borrow pointer) | |||
| public init<T: BitwiseCopyable>( | |||
| _unsafeStart pointer: UnsafePointer<T>, | |||
| count: Int | |||
| byteCount: Int | |||
There was a problem hiding this comment.
This really is count. It is the number of T elements. Below, we passed count * MemoryLayout<T>.stride to the byteCount-taking initializer. It would also be source-breaking, which we will only want to do when we officially review the RawSpan initializers and deprecate this spelling.
For now, let's remove the changes from lines 304-308. Thanks!
There was a problem hiding this comment.
I have reverted this change and fixed this func's doc comment to match parameters naming.
…oc comment and match other methods" This reverts commit 4129383.
|
@swift-ci please smoke test |
glessard
reviewed
Jun 9, 2025
glessard
reviewed
Jun 9, 2025
glessard
reviewed
Jun 9, 2025
Co-authored-by: Guillaume Lessard <[email protected]>
Co-authored-by: Guillaume Lessard <[email protected]>
glessard
approved these changes
Jun 9, 2025
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux platform |
|
@swift-ci smoke test linux |
|
@swift-ci smoke test Linux platform |
1 similar comment
|
@swift-ci smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.